Build and publish images via GitHub Actions#2
Merged
Conversation
Adds a workflow that auto-detects every version directory containing a Dockerfile, builds it on every PR (to catch Dockerfile regressions before merge), and publishes to Docker Hub on merge to master. Removes the manual Docker Desktop ceremony from the README and documents the two repo secrets the workflow needs (DOCKERHUB_USERNAME and DOCKERHUB_TOKEN). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
.github/workflows/publish.ymlthat:Dockerfilemaster, pushes each asdefactosoftware/elixir:<dir-name>type=ghaper-version so subsequent builds are fastAlso updates the README: drops the Docker Desktop ceremony, documents the new flow, and lists the two repo secrets the workflow needs.
Required setup before merging
Add two repo secrets in Settings → Secrets and variables → Actions:
DOCKERHUB_USERNAME— a Docker Hub account with push access todefactosoftware/elixirDOCKERHUB_TOKEN— a Docker Hub access token (https://hub.docker.com/settings/security)Without these, the publish step on merge to master will fail at login. PR builds don't need them — they only build (no push).
Why now
We're adding
1.20.0-rc.6(#1) and the detroit CI is blocked on that image being on Docker Hub. Wiring up CI here means future version bumps are just PR → merge, no manualdocker build/docker pushdance.Notes / non-goals
linux/amd64only — matches the existing manual flow. Addinglinux/arm64for Apple Silicon devcontainer users would be a one-line change if wanted later.1.18.1removed it) — leaving that for a follow-up to keep this PR focused.Test plan
1.18.0and1.18.1(build-only, no push)defactosoftware/elixir:1.18.0anddefactosoftware/elixir:1.18.1(re-pushes existing tags as a no-op smoke test)1.20.0-rc.6🤖 Generated with Claude Code